Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jun 15, 2023

Description

  • scan tests/_support/Controllers for Psalm

I don't know why these errors are reported.

ERROR: UndefinedClass - tests/system/CodeIgniterTest.php:114:33 - Class, interface or enum named Tests\Support\Controllers\Hello does not exist (see https://psalm.dev/019)
        $routes->set404Override('Tests\Support\Controllers\Hello::index');


ERROR: UndefinedClass - tests/system/CodeIgniterTest.php:133:33 - Class, interface or enum named Tests\Support\Controllers\Popcorn does not exist (see https://psalm.dev/019)
        $routes->set404Override('Tests\Support\Controllers\Popcorn::pop');


ERROR: UndefinedClass - tests/system/CodeIgniterTest.php:152:33 - Class, interface or enum named Tests\Support\Controllers\Popcorn does not exist (see https://psalm.dev/019)
        $routes->set404Override('Tests\Support\Controllers\Popcorn::pop');

https://github.com/codeigniter4/CodeIgniter4/actions/runs/5276222376/jobs/9542644621

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis force-pushed the fix-psalm_autoload.php branch 2 times, most recently from 5af5598 to e01a87a Compare June 15, 2023 09:51
@kenjis kenjis force-pushed the fix-psalm_autoload.php branch from e01a87a to 8e5c50e Compare June 15, 2023 09:53
@kenjis kenjis changed the title chore: scan tests/_support for Psalm chore: scan tests/_support/Controllers for Psalm Jun 15, 2023
@kenjis kenjis changed the title chore: scan tests/_support/Controllers for Psalm chore: [Psalm] workarround for Tests\Support\Controllers\Hello does not exist Jun 16, 2023
@kenjis
Copy link
Member Author

kenjis commented Jun 16, 2023

In this check, there is only one error.

ERROR: UndefinedClass - tests/system/CodeIgniterTest.php:114:33 - Class, interface or enum named Tests\Support\Controllers\Hello does not exist (see https://psalm.dev/019)
        $routes->set404Override('Tests\Support\Controllers\Hello::index');

https://github.com/codeigniter4/CodeIgniter4/actions/runs/5284903965/jobs/9562840079

@kenjis kenjis merged commit eea5087 into codeigniter4:develop Jun 17, 2023
@kenjis kenjis deleted the fix-psalm_autoload.php branch June 17, 2023 00:23
@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants