Skip to content

refactor: [Auto Routing Improved] ensure $httpVerb is lower case #7575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

refactor: [Auto Routing Improved] ensure $httpVerb is lower case #7575

merged 1 commit into from
Jun 15, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jun 14, 2023 •
edited
Loading

Description
Follow-up #7543

$httpVerb is used later in the method. So the value should be lower case.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jun 14, 2023
@kenjis kenjis merged commit 95be341 into codeigniter4:develop Jun 15, 2023
@kenjis kenjis deleted the refactor-AutoRouterImproved-getRoute branch June 15, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis @michalsn @samsonasik @paulbalandan