Skip to content

fix: [QueryBuilder] incorrect SQL without space before "ON DUPLICATE KEY UPDATE" #7564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix: [QueryBuilder] incorrect SQL without space before "ON DUPLICATE KEY UPDATE" #7564

merged 1 commit into from
Jun 13, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jun 12, 2023

Description
Fixes #7563

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jun 12, 2023
@kenjis kenjis force-pushed the fix-qb-upsertBatch branch from 7b77858 to ef76729 Compare June 12, 2023 23:59
@kenjis kenjis mentioned this pull request Jun 13, 2023
Closed
@kenjis kenjis merged commit c603406 into codeigniter4:develop Jun 13, 2023
@kenjis kenjis deleted the fix-qb-upsertBatch branch June 13, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: sql error ON DUPLICATE KEY UPDATE (in the upsertBatch method)

2 participants

@kenjis @michalsn