Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jun 6, 2023

Description

 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   system/Entity/Entity.php                                                                                                                  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 
  455    Method CodeIgniter\Entity\Entity::__set() with return type void returns $this(CodeIgniter\Entity\Entity) but should not return anything.  
  464    Method CodeIgniter\Entity\Entity::__set() with return type void returns $this(CodeIgniter\Entity\Entity) but should not return anything.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------ 

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jun 6, 2023
@kenjis kenjis changed the title refactor: fix incorrect return value refactor: [Entity] fix incorrect return value Jun 6, 2023
@kenjis kenjis merged commit 335ab86 into codeigniter4:develop Jun 6, 2023
@kenjis kenjis deleted the fix-Entity-return-type branch June 6, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants