Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Apr 25, 2023

Description
Small improvements.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Apr 25, 2023
- MSSQL via the *SQLSRV* driver (version 2005 and above only)
- Oracle via the *OCI8* driver (version 12.1 and above only)
- MySQL via the ``MySQLi`` driver (version 5.1 and above only)
- PostgreSQL via the ``Postgre`` driver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- PostgreSQL via the ``Postgre`` driver
- PostgreSQL via the ``Postgre`` driver

Not consistent in configuration file, use Postgres or Postgre? I am not using PostgreSQL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It is the directory name for the driver. That is Postgre.

@kenjis kenjis requested a review from ddevsr April 26, 2023 03:41
@kenjis
Copy link
Member Author

kenjis commented Apr 26, 2023

Fixed wrong db driver names.

@kenjis kenjis requested a review from datamweb April 26, 2023 03:43
@kenjis kenjis merged commit f89ec81 into codeigniter4:develop Apr 26, 2023
@kenjis kenjis deleted the docs-dbdriver branch April 26, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants