Skip to content

Conversation

@ping-yee
Copy link
Contributor

Description
See #6310

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

* @return mixed
*/
public function add(string $from, $to, ?array $options = null);
public function add(string $from, $to, ?array $options = null): self;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change.
https://3v4l.org/n9AYI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been removed.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust this to docblock changes only

@ping-yee
Copy link
Contributor Author

OK, I'll change it later.

@ping-yee
Copy link
Contributor Author

ping-yee commented Apr 22, 2023

I have been fixed and review please.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MGatner MGatner merged commit 8606a6b into codeigniter4:develop Apr 23, 2023
@ping-yee ping-yee deleted the replace-mixed-router branch April 25, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants