Skip to content

Conversation

@ping-yee
Copy link
Contributor

@ping-yee ping-yee commented Apr 14, 2023

Description
See #6310

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't confirmed all the possibilities in the code but these look correct on review. Anyone from @codeigniter4/database-team want to give a second look?

@kenjis kenjis merged commit 6c346b6 into codeigniter4:develop Apr 25, 2023
@kenjis
Copy link
Member

kenjis commented Apr 25, 2023

@ping-yee Thank you!

@ping-yee ping-yee deleted the replace-type-db-result branch April 25, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants