Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Feb 8, 2023

Description
This PR is required for #7239.

When registering Exception Handler, Request object was generated.
But it was too early, and difficult to understand.

Before:

Services.php:535, CodeIgniter\Config\Services::incomingrequest()
Services.php:501, CodeIgniter\Config\Services::request()
BaseService.php:252, CodeIgniter\Config\BaseService::__callStatic()
BaseService.php:193, CodeIgniter\Config\BaseService::request()
BaseService.php:193, CodeIgniter\Config\BaseService::getSharedInstance()
Services.php:497, CodeIgniter\Config\Services::request()
BaseService.php:252, CodeIgniter\Config\BaseService::__callStatic()
Services.php:265, CodeIgniter\Config\BaseService::request()
Services.php:265, CodeIgniter\Config\Services::exceptions()
BaseService.php:252, CodeIgniter\Config\BaseService::__callStatic()
BaseService.php:193, CodeIgniter\Config\BaseService::exceptions()
BaseService.php:193, CodeIgniter\Config\BaseService::getSharedInstance()
Services.php:261, CodeIgniter\Config\Services::exceptions()
BaseService.php:252, CodeIgniter\Config\BaseService::__callStatic()
CodeIgniter.php:186, CodeIgniter\Config\BaseService::exceptions()
CodeIgniter.php:186, CodeIgniter\CodeIgniter->initialize()
index.php:55, require_once()
rewrite.php:47, {main}()

After:

Services.php:539, CodeIgniter\Config\Services::incomingrequest()
BaseService.php:252, CodeIgniter\Config\BaseService::__callStatic()
Services.php:520, CodeIgniter\Config\BaseService::incomingrequest()
Services.php:520, CodeIgniter\Config\Services::createRequest()
BaseService.php:252, CodeIgniter\Config\BaseService::__callStatic()
CodeIgniter.php:646, CodeIgniter\Config\BaseService::createRequest()
CodeIgniter.php:646, CodeIgniter\CodeIgniter->getRequestObject()
CodeIgniter.php:331, CodeIgniter\CodeIgniter->run()
index.php:67, require_once()
rewrite.php:47, {main}()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

When registering Exception Handler, Request object was generated.
But it was too early, and difficult to understand.
@kenjis kenjis added refactor Pull requests that refactor code 4.4 labels Feb 8, 2023
@kenjis kenjis mentioned this pull request Feb 10, 2023
5 tasks
@kenjis kenjis merged commit 98300a4 into codeigniter4:4.4 Feb 17, 2023
@kenjis kenjis deleted the fix-Exceptions-construct branch February 17, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants