refactor: remove Cookie config items in Config\App #7221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
force-pushed
the
remove-config-app-cookie-4.4
branch
from
8c33b5d to
01f7a6b
Compare
michalsn
approved these changes
Feb 5, 2023
Member
michalsn
left a comment
michalsn
left a comment
There was a problem hiding this comment.
As you know, I'm not a fan of removing things like this in a minor version, but since others think differently and there is an agreement about it (I as understand) then I only checked the code and it seems ok 👍
MGatner
approved these changes
Feb 6, 2023
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Actually glad to see this one happen. Hopefully not too many repercussions for devs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #7011
This PR is needed to fix Session Config issue: #4297 (comment) → #7255
Checklist: