Skip to content

docs: improve route_to() and url_to() #7090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 25, 2023
Merged

docs: improve route_to() and url_to() #7090

merged 11 commits into from
Jan 25, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jan 11, 2023

Description

  • update PHPDoc
  • update User Guide
  • fix sample code
  • add test

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only documentation Pull requests for documentation only labels Jan 11, 2023
datamweb
datamweb reviewed Jan 12, 2023
View reviewed changes
@kenjis
Copy link
Member Author

kenjis commented Jan 13, 2023

By the way, do we need route_to()?
I don't see there is a particular use case.

@lonnieezell
Copy link
Member

lonnieezell commented Jan 13, 2023

route_to works with named routes and controller/methods instead of urls so yes I think it still needs to stay.

@kenjis kenjis force-pushed the fix-docs-route-to-url-to branch from b0a8ea0 to 76b1124 Compare January 14, 2023 00:13
@kenjis
Copy link
Member Author

kenjis commented Jan 14, 2023

Rebased and add a commit.

@kenjis kenjis force-pushed the fix-docs-route-to-url-to branch from 76b1124 to 2435311 Compare January 20, 2023 02:38
@kenjis
Copy link
Member Author

kenjis commented Jan 20, 2023 •
edited
Loading

Rebased and added 4 commits.

@kenjis
Copy link
Member Author

kenjis commented Jan 20, 2023

Please review.

@kenjis
Copy link
Member Author

kenjis commented Jan 25, 2023

Can anyone review this?

@kenjis kenjis merged commit ecef7f7 into codeigniter4:develop Jan 25, 2023
@kenjis kenjis deleted the fix-docs-route-to-url-to branch January 25, 2023 22:49
@kenjis
Copy link
Member Author

kenjis commented Jan 25, 2023

Thanks! @samsonasik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

+1 more reviewer

@datamweb datamweb datamweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests for documentation only testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis @lonnieezell @samsonasik @datamweb