Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Dec 4, 2022

Description
Follow-up #6088

codeigniter4/framework
also should have this file.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

codeigniter4/framework also should have this file.
@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Dec 4, 2022
@samsonasik
Copy link
Member

If preload.php is on framework part, which in vendor/ location already, the documentation usage may need update:

'include' => __DIR__ . '/vendor/codeigniter4/framework/system',

* 1. Set preload::$paths.

Or probably better change to:

'include' => __DIR__ . '/system',

on inside framework

@kenjis
Copy link
Member Author

kenjis commented Dec 4, 2022

Updated the comment.

The preload.php should be located in the project root folder.
Devs should customize it.

If it is only in appstarter,

  1. devs who do not use appstarter can't get it easily.
  2. when it is updated, devs can't update it easily.

Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@samsonasik samsonasik merged commit 7b950bd into codeigniter4:develop Dec 4, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-move-preload.php branch December 4, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants