Skip to content

fix: [4.3] remove ignoreErrors item for PHPStan 1.9.0 #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix: [4.3] remove ignoreErrors item for PHPStan 1.9.0 #6811

merged 1 commit into from
Nov 4, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Nov 4, 2022 •
edited
Loading

Needs #6810

Description

  • PHPStan 1.9.0 reported errors.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title fix: [4.3] variable types for PHPStan 1.9.0 fix: [4.3] remove ignoreErrors item for PHPStan 1.9.0 Nov 4, 2022
@kenjis kenjis changed the base branch from develop to 4.3 November 4, 2022 00:42
@kenjis kenjis added the 4.3 label Nov 4, 2022
@kenjis
chore: remove ignoreErrors item
03d84e4 
PHPStan 1.9.0 reported:
 ------ ----------------------------------------------------------------------------------------------------------
  Line   system/CLI/Console.php
 ------ ----------------------------------------------------------------------------------------------------------
         Ignored error pattern #^Strict comparison using === between array<mixed, mixed> and array{} will always
         evaluate to false\.$# in path /.../CodeIgniter4/system/CLI/Console.php
         was not matched in reported errors.
 ------ ----------------------------------------------------------------------------------------------------------
@kenjis kenjis force-pushed the fix-4.3-phpstan-190-erros branch from 2409c83 to 03d84e4 Compare November 4, 2022 01:25
@samsonasik samsonasik merged commit 0fff1c9 into codeigniter4:4.3 Nov 4, 2022
@samsonasik
Copy link
Member

samsonasik commented Nov 4, 2022

Thank you @kenjis

@kenjis kenjis deleted the fix-4.3-phpstan-190-erros branch November 4, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @samsonasik