Skip to content

docs: fix PHPDoc types in Session #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

docs: fix PHPDoc types in Session #6796

merged 1 commit into from
Oct 31, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Oct 31, 2022

Description
See codeigniter4/shield#492

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Oct 31, 2022
Closed
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 31, 2022
datamweb
datamweb approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀🥀.

@kenjis kenjis merged commit a6fdf0e into codeigniter4:develop Oct 31, 2022
@kenjis kenjis deleted the fix-phpdoc-Session branch October 31, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis @datamweb @MGatner @paulbalandan