Skip to content

Fix faker access deprecations #6787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

Fix faker access deprecations #6787

merged 1 commit into from
Oct 30, 2022

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Oct 30, 2022

Description
Fixes #6764
Related: #6773

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Oct 30, 2022
@samsonasik samsonasik merged commit bb45109 into codeigniter4:develop Oct 30, 2022
@samsonasik
Copy link
Member

samsonasik commented Oct 30, 2022

Thank you @paulbalandan

@paulbalandan paulbalandan deleted the faker-deprecations branch October 30, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: errorHandler removes Faker's deprecated errors

3 participants

@paulbalandan @samsonasik @kenjis