Skip to content

fix: [SQLSRV] _getResult() return object for preparedQuery class #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 23, 2022
Merged

fix: [SQLSRV] _getResult() return object for preparedQuery class #6718

merged 5 commits into from
Oct 23, 2022

Conversation

@michalsn
Copy link
Member

@michalsn michalsn commented Oct 19, 2022

Description
This PR fixes the result object for CodeIgniter\Database\SQLSRV\PreparedQuery::_getResult().

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Oct 19, 2022
paulbalandan
paulbalandan approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

MGatner
MGatner approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good. I don't understand the underlying reason, but that's why we have the @codeigniter4/database-team 😎

sclubricants
sclubricants suggested changes Oct 20, 2022
View reviewed changes
@kenjis kenjis changed the title fix: _getResult() return object for preparedQuery class in sqlsrv fix: _getResult() return object for preparedQuery class in SQLSRV Oct 20, 2022
@michalsn
Copy link
Member Author

michalsn commented Oct 21, 2022

@sclubricants Thanks for the feedback. Everything should be fixed now.

@michalsn
Copy link
Member Author

michalsn commented Oct 21, 2022 •
edited
Loading

Just a note...

Sadly, now I see there is another problem. And it involves the BasePreparedQuery class in general. We always return the Result class, which should not happen. I guess changes to the BasePreparedQuery class were missed when we made changes in the past: #4176

I mean... I simply forgot about it.

Anyway, this should be addressed and fixed in a separate PR.

@michalsn michalsn requested a review from sclubricants October 21, 2022 16:37
sclubricants
sclubricants reviewed Oct 21, 2022
View reviewed changes
Copy link
Member

@sclubricants sclubricants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to mention that it returns false on failure. Other than that looks good.

@kenjis kenjis changed the title fix: _getResult() return object for preparedQuery class in SQLSRV fix: [SQLSRV] _getResult() return object for preparedQuery class Oct 21, 2022
@michalsn michalsn force-pushed the fix/sqlsrv-preparedQuery-result branch from c92c2e7 to 7e5d98e Compare October 23, 2022 07:07
@michalsn michalsn merged commit 35e3664 into codeigniter4:develop Oct 23, 2022
@michalsn michalsn deleted the fix/sqlsrv-preparedQuery-result branch December 13, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@sclubricants sclubricants sclubricants requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michalsn @kenjis @sclubricants @MGatner @paulbalandan