Skip to content

refactor: remove unneeded abstract public methods #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2022
Merged

refactor: remove unneeded abstract public methods #6713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions system/Database/BaseConnection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,13 +426,6 @@ public function initialize()
$this->connectDuration = microtime(true) - $this->connectTime;
}

/**
* Connect to the database.
*
* @return mixed
*/
abstract public function connect(bool $persistent = false);

/**
* Close the database connection.
*/
Expand Down Expand Up @@ -461,14 +454,6 @@ public function persistentConnect()
return $this->connect(true);
}

/**
* Keep or establish the connection if no queries have been sent for
* a length of time exceeding the server's idle timeout.
*
* @return mixed
*/
abstract public function reconnect();

/**
* Returns the actual connection object. If both a 'read' and 'write'
* connection has been specified, you can pass either term in to
Expand All @@ -483,13 +468,6 @@ public function getConnection(?string $alias = null)
return $this->connID;
}

/**
* Select a specific database table to use.
*
* @return mixed
*/
abstract public function setDatabase(string $databaseName);

/**
* Returns the name of the current database being used.
*/
Expand Down Expand Up @@ -526,11 +504,6 @@ public function getPlatform(): string
return $this->DBDriver;
}

/**
* Returns a string containing the version of the database being used.
*/
abstract public function getVersion(): string;

/**
* Sets the Table Aliases to use. These are typically
* collected during use of the Builder, and set here
Expand Down