-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: custom exception handler #6710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
54cc18b
feat: add Debug\ExceptionHandler
kenjis ebf59e8
refactor: use ExceptionHandler
kenjis a7fb791
docs: add user guide
kenjis 45fe5a7
fix: cannot override $viewPath
kenjis fa31541
refactor: run rector & cs-fixer
kenjis 9d724dc
chore: update test-phpcpd.yml
kenjis 550e62e
refactor: run rector
kenjis 7777772
fix: set deprecated properties for backward compatibility
kenjis 038717a
docs: add Deprecations
kenjis 4a8bc0d
refactor: move ResponseTrait to ExceptionHandler
kenjis 30133af
docs: add @deprecated
kenjis d1e7678
docs: fix changelog
kenjis f41f2ef
docs: add @used-by
kenjis a610d48
refactor: use number helper
kenjis 50b02c8
refactor: make final class
kenjis 9d5d44f
refactor: remove defaultExceptionHandler() and use ExceptionHandler
kenjis dc9fc53
refactor: run rector
kenjis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,233 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * This file is part of CodeIgniter 4 framework. | ||
| * | ||
| * (c) CodeIgniter Foundation <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view | ||
| * the LICENSE file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace CodeIgniter\Debug; | ||
|
|
||
| use CodeIgniter\HTTP\RequestInterface; | ||
| use CodeIgniter\HTTP\ResponseInterface; | ||
| use Config\Exceptions as ExceptionsConfig; | ||
| use Throwable; | ||
|
|
||
| /** | ||
| * Provides common functions for exception handlers, | ||
| * especially around displaying the output. | ||
| */ | ||
| abstract class BaseExceptionHandler | ||
| { | ||
| /** | ||
| * Config for debug exceptions. | ||
| */ | ||
| protected ExceptionsConfig $config; | ||
|
|
||
| /** | ||
| * Nesting level of the output buffering mechanism | ||
| */ | ||
| protected int $obLevel; | ||
|
|
||
| /** | ||
| * The path to the directory containing the | ||
| * cli and html error view directories. | ||
| */ | ||
| protected ?string $viewPath = null; | ||
|
|
||
| public function __construct(ExceptionsConfig $config) | ||
| { | ||
| $this->config = $config; | ||
|
|
||
| $this->obLevel = ob_get_level(); | ||
|
|
||
| if ($this->viewPath === null) { | ||
| $this->viewPath = rtrim($this->config->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * The main entry point into the handler. | ||
| * | ||
| * @return void | ||
| */ | ||
| abstract public function handle( | ||
| Throwable $exception, | ||
| RequestInterface $request, | ||
| ResponseInterface $response, | ||
| int $statusCode, | ||
| int $exitCode | ||
| ); | ||
|
|
||
| /** | ||
| * Gathers the variables that will be made available to the view. | ||
| */ | ||
| protected function collectVars(Throwable $exception, int $statusCode): array | ||
| { | ||
| $trace = $exception->getTrace(); | ||
|
|
||
| if ($this->config->sensitiveDataInTrace !== []) { | ||
| $this->maskSensitiveData($trace, $this->config->sensitiveDataInTrace); | ||
| } | ||
|
|
||
| return [ | ||
| 'title' => get_class($exception), | ||
| 'type' => get_class($exception), | ||
| 'code' => $statusCode, | ||
| 'message' => $exception->getMessage(), | ||
| 'file' => $exception->getFile(), | ||
| 'line' => $exception->getLine(), | ||
| 'trace' => $trace, | ||
| ]; | ||
| } | ||
|
|
||
| /** | ||
| * Mask sensitive data in the trace. | ||
| * | ||
| * @param array|object $trace | ||
| */ | ||
| protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '') | ||
| { | ||
| foreach ($keysToMask as $keyToMask) { | ||
| $explode = explode('/', $keyToMask); | ||
| $index = end($explode); | ||
|
|
||
| if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) { | ||
| if (is_array($trace) && array_key_exists($index, $trace)) { | ||
| $trace[$index] = '******************'; | ||
| } elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) { | ||
| $trace->{$index} = '******************'; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (is_object($trace)) { | ||
| $trace = get_object_vars($trace); | ||
| } | ||
|
|
||
| if (is_array($trace)) { | ||
| foreach ($trace as $pathKey => $subarray) { | ||
| $this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Describes memory usage in real-world units. Intended for use | ||
| * with memory_get_usage, etc. | ||
| * | ||
| * @used-by app/Views/errors/html/error_exception.php | ||
| */ | ||
| protected static function describeMemory(int $bytes): string | ||
| { | ||
| helper('number'); | ||
|
|
||
| return number_to_size($bytes, 2); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a syntax-highlighted version of a PHP file. | ||
| * | ||
| * @used-by app/Views/errors/html/error_exception.php | ||
| * | ||
| * @return bool|string | ||
| */ | ||
| protected static function highlightFile(string $file, int $lineNumber, int $lines = 15) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the existing handler doesn't actually extend this base, can we go ahead and type this?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you mean? |
||
| { | ||
| if (empty($file) || ! is_readable($file)) { | ||
| return false; | ||
| } | ||
|
|
||
| // Set our highlight colors: | ||
| if (function_exists('ini_set')) { | ||
| ini_set('highlight.comment', '#767a7e; font-style: italic'); | ||
| ini_set('highlight.default', '#c7c7c7'); | ||
| ini_set('highlight.html', '#06B'); | ||
| ini_set('highlight.keyword', '#f1ce61;'); | ||
| ini_set('highlight.string', '#869d6a'); | ||
| } | ||
|
|
||
| try { | ||
| $source = file_get_contents($file); | ||
| } catch (Throwable $e) { | ||
| return false; | ||
| } | ||
|
|
||
| $source = str_replace(["\r\n", "\r"], "\n", $source); | ||
| $source = explode("\n", highlight_string($source, true)); | ||
| $source = str_replace('<br />', "\n", $source[1]); | ||
| $source = explode("\n", str_replace("\r\n", "\n", $source)); | ||
|
|
||
| // Get just the part to show | ||
| $start = max($lineNumber - (int) round($lines / 2), 0); | ||
|
|
||
| // Get just the lines we need to display, while keeping line numbers... | ||
| $source = array_splice($source, $start, $lines, true); | ||
|
|
||
| // Used to format the line number in the source | ||
| $format = '% ' . strlen((string) ($start + $lines)) . 'd'; | ||
|
|
||
| $out = ''; | ||
| // Because the highlighting may have an uneven number | ||
| // of open and close span tags on one line, we need | ||
| // to ensure we can close them all to get the lines | ||
| // showing correctly. | ||
| $spans = 1; | ||
|
|
||
| foreach ($source as $n => $row) { | ||
| $spans += substr_count($row, '<span') - substr_count($row, '</span'); | ||
| $row = str_replace(["\r", "\n"], ['', ''], $row); | ||
|
|
||
| if (($n + $start + 1) === $lineNumber) { | ||
| preg_match_all('#<[^>]+>#', $row, $tags); | ||
|
|
||
| $out .= sprintf( | ||
| "<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s", | ||
| $n + $start + 1, | ||
| strip_tags($row), | ||
| implode('', $tags[0]) | ||
| ); | ||
| } else { | ||
| $out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n"; | ||
| } | ||
| } | ||
|
|
||
| if ($spans > 0) { | ||
| $out .= str_repeat('</span>', $spans); | ||
| } | ||
|
|
||
| return '<pre><code>' . $out . '</code></pre>'; | ||
| } | ||
|
|
||
| /** | ||
| * Given an exception and status code will display the error to the client. | ||
| * | ||
| * @param string|null $viewFile | ||
| */ | ||
| protected function render(Throwable $exception, int $statusCode, $viewFile = null): void | ||
| { | ||
| if (empty($viewFile) || ! is_file($viewFile)) { | ||
| echo 'The error view files were not found. Cannot render exception trace.'; | ||
|
|
||
| exit(1); | ||
| } | ||
|
|
||
| if (ob_get_level() > $this->obLevel + 1) { | ||
| ob_end_clean(); | ||
| } | ||
|
|
||
| echo(function () use ($exception, $statusCode, $viewFile): string { | ||
| $vars = $this->collectVars($exception, $statusCode); | ||
| extract($vars, EXTR_SKIP); | ||
|
|
||
| // CLI error views output to STDERR/STDOUT, so ob_start() does not work. | ||
| ob_start(); | ||
| include $viewFile; | ||
|
|
||
| return ob_get_clean(); | ||
| })(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.