Skip to content

Fix testMode() with upsert() and getCompiledUpsert() #6697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2022
Merged

Fix testMode() with upsert() and getCompiledUpsert() #6697

merged 2 commits into from
Oct 19, 2022

Conversation

@sclubricants
Copy link
Member

@sclubricants sclubricants commented Oct 15, 2022 •
edited by kenjis
Loading

Fixes #6687
Follow-up #6600

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@sclubricants
Fix testMode() with upsert()
9feaf2c 
Only resetRun() if not in test mode.
@sclubricants
Add Test
f7ef247
@sclubricants sclubricants added bug Verified issues on the current code behavior or pull requests that will fix them 4.3 labels Oct 15, 2022
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Oct 17, 2022
@kenjis kenjis merged commit b166875 into codeigniter4:4.3 Oct 19, 2022
@kenjis kenjis mentioned this pull request Oct 19, 2022
Closed
@sclubricants sclubricants deleted the FixTestModeWithUpsert branch October 20, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sclubricants @kenjis