Skip to content

Fix UpsertTest::testUpsertWithMultipleSet #6692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2022
Merged

Fix UpsertTest::testUpsertWithMultipleSet #6692

merged 3 commits into from
Oct 15, 2022

Conversation

@sclubricants
Copy link
Member

@sclubricants sclubricants commented Oct 15, 2022 •
edited by kenjis
Loading

Follow-up #6600

SQLite was using GMT time and not timezone set on OS.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@sclubricants sclubricants added bug Verified issues on the current code behavior or pull requests that will fix them 4.3 labels Oct 15, 2022
@sclubricants sclubricants mentioned this pull request Oct 15, 2022
Closed
@sclubricants
Copy link
Member Author

sclubricants commented Oct 15, 2022

Now Postgre

@kenjis
Copy link
Member

kenjis commented Oct 15, 2022

It seems SQLite test still fails:
https://github.com/codeigniter4/CodeIgniter4/actions/runs/3253838286/jobs/5341483157

@kenjis
Copy link
Member

kenjis commented Oct 15, 2022

Your fix changed the SQLite time to real my localtime.
But my timezone is not the same with the CI4 default timezone,
so the test fails.

@sclubricants
Copy link
Member Author

sclubricants commented Oct 15, 2022

Should be fixed for good. I statically set the date

@kenjis kenjis added the testing Pull requests that changes tests only label Oct 15, 2022
kenjis
kenjis reviewed Oct 15, 2022
View reviewed changes
@kenjis
Copy link
Member

kenjis commented Oct 15, 2022

Oh, it looks good!

@sclubricants
Copy link
Member Author

sclubricants commented Oct 15, 2022

Merge!

@kenjis kenjis merged commit 00d2b2a into codeigniter4:4.3 Oct 15, 2022
@sclubricants sclubricants deleted the FixUpsertTest branch October 20, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sclubricants @kenjis