Skip to content

Use environment variables instead of set-output #6680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

Use environment variables instead of set-output #6680

merged 1 commit into from
Oct 17, 2022

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Oct 13, 2022 •
edited by kenjis
Loading

Description
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis
kenjis approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Oct 14, 2022
MGatner
MGatner reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would you please replicate any relevant changes to the templates at DevKit?

@paulbalandan paulbalandan mentioned this pull request Oct 15, 2022
Merged
@paulbalandan
Copy link
Member Author

paulbalandan commented Oct 15, 2022

Done.

@paulbalandan paulbalandan merged commit f6a0343 into codeigniter4:develop Oct 17, 2022
@paulbalandan paulbalandan deleted the set-output-deprecation branch October 17, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner left review comments

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @kenjis @MGatner