Skip to content

docs: improve "If You Sent to the Wrong Branch" #6659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

docs: improve "If You Sent to the Wrong Branch" #6659

merged 1 commit into from
Oct 11, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Oct 10, 2022

Description

  • use git rebase --onto

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis requested a review from MGatner October 10, 2022 21:44
MGatner
MGatner reviewed Oct 10, 2022
View reviewed changes
MGatner
MGatner approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using the --onto a lot when I'm working on a branch of my own branch while it is in testing but then needs to be rebased before approval. Love it.

@kenjis kenjis merged commit 906eade into codeigniter4:develop Oct 11, 2022
@kenjis kenjis deleted the fix-docs-PR-wrong-branch branch October 11, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @MGatner