-
Notifications
You must be signed in to change notification settings - Fork 2k
refactor: replace global $app with Services
#6524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace global $app with Services
#6524
Conversation
global $app changed.
global $app changed.global $app changed.
global $app changed.global $app with Services
|
I understand the reason for this PR, but I don't think it's the right solution. To begin with, the I also think that the design of the toolbar filter is bad. Instead of simply injecting a toolbar header or script into the response, data collection is additionally triggered. I think the way the toolbar works should be changed instead of using Codeigniter::class
|
|
@iRedds Thanks for your advices, I understand what you mean and feel grateful. |
|
@iRedds It seems true what you say, but this PR fixes the bug in Long-living PHP like RoadRunner. |
|
I just expressed my opinion. |
|
@ping-yee Can you remove this? CodeIgniter4/system/Debug/Toolbar.php Line 354 in e1dbce0
|
|
@iRedds Thank you for your opinion. You can send a PR to fix the bad design of the debugbar later. |
|
@kenjis I have been taken out the comment out, appreciated that! |
Description
Modified #6523.
Checklist: