Skip to content

fix: Parse error occurs before PHP version check #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

fix: Parse error occurs before PHP version check #6327

merged 1 commit into from
Aug 3, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 1, 2022 •
edited
Loading

Description
Fixes #6306

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
fix: move PHP version check to index.php/spark
6ac3a7b 
If we use new syntax in new PHP version when dropping older PHP version support,
syntax error occurs before the PHP version check.
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 1, 2022
MGatner
MGatner approved these changes Aug 1, 2022
View reviewed changes
system/CodeIgniter.php
ob_end_flush(); // @codeCoverageIgnore
}

// Throws new PageNotFoundException and remove exception message on production.
Copy link
Member

@MGatner MGatner Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this got scooped up by mistake?

Copy link
Member Author

@kenjis kenjis Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes. It is not related to this PR.

@totoprayogo1916
Copy link
Contributor

totoprayogo1916 commented Aug 2, 2022

then https://github.com/kenjis/CodeIgniter4/blob/6ac3a7bfe48e72b687c5727cd60f88b9724da4ac/system/Language/en/Core.php#L17
should be removed

@kenjis kenjis mentioned this pull request Aug 3, 2022
Closed
5 tasks
@kenjis kenjis merged commit 71edcc9 into codeigniter4:develop Aug 3, 2022
@kenjis kenjis deleted the fix-php-version-check branch August 3, 2022 08:31
@totoprayogo1916 totoprayogo1916 mentioned this pull request Aug 17, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parse error: syntax error, unexpected '_536_000' (T_STRING), expecting ')'

3 participants

@kenjis @totoprayogo1916 @MGatner