Skip to content

fix: Entity::hasChanged() returns wrong result to mapped property #6285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 24, 2022
Merged

fix: Entity::hasChanged() returns wrong result to mapped property #6285

merged 7 commits into from
Jul 24, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jul 22, 2022 •
edited
Loading

Description

  • fix Entity::hasChanged() returns wrong result to mapped property
  • fix PHPDoc types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 22, 2022
@kenjis kenjis mentioned this pull request Jul 22, 2022
Closed
5 tasks
@kenjis kenjis merged commit f781dc2 into codeigniter4:develop Jul 24, 2022
@kenjis kenjis deleted the fix-Entity-hasChanged-mapped-property branch July 24, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @MGatner