-
Notifications
You must be signed in to change notification settings - Fork 2k
Config Property Types #6189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config Property Types #6189
Conversation
|
This should all be safe to change with the possible exception of |
|
Actually this may not work because of the class extensions in |
|
|
I saw that, there are a few other Configs in there that break as well. If we want to move forward with this I think the approach would be to remove the properties from the Mock Config files and use their constructors to change the values that need changing. That way they would still work with whatever is in a user's app/Config folder, typed or not. |
|
It would be impossible to ensure that an existing app or tests would never break |
|
But that is only if the developer manually updates their Config folder with the new files. This should be safe with the caveat of these Mock classes, which we can fix internally but can't guarantee that extensions don't exist. |
Yes, you are correct! |
|
#6214 was merged. |
Description
Applies non-breaking property types to Config files in
App. Applied by Rector.Checklist: