Skip to content

test: change Config\Images::$libraryPath only when the file exists #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2022
Merged

test: change Config\Images::$libraryPath only when the file exists #6011

merged 1 commit into from
May 20, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented May 20, 2022

Description
When there is no /usr/bin/convert, the errors occurs.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label May 20, 2022
@samsonasik samsonasik merged commit 044ccbb into codeigniter4:develop May 20, 2022
@samsonasik
Copy link
Member

samsonasik commented May 20, 2022

Thank you @kenjis

@kenjis kenjis deleted the fix-ImageMagickHandlerTest branch October 2, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @samsonasik @paulbalandan