Skip to content

Conversation

@iRedds
Copy link
Collaborator

@iRedds iRedds commented May 17, 2022

Description
Because Oracle does not support using the AS keyword for table aliases.
This PR removes the AS keyword when building subqueries.

Checklist:

  • Securely signed commits
  • User guide updated

iRedds added 2 commits May 17, 2022 08:51
Signed-off-by: Andrey Pyzhikov <[email protected]>
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label May 18, 2022
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in the changelog as people might be expecting in their tests the AS in the SQL.

@kenjis
Copy link
Member

kenjis commented May 18, 2022

Subquery has not been released. Do we need it to be written in the changelog?
https://codeigniter4.github.io/CodeIgniter4/changelogs/v4.2.0.html#others

@iRedds
Copy link
Collaborator Author

iRedds commented May 18, 2022

@paulbalandan An improvement to the BaseBuilder::buildSubquery() method, namely adding an alias, has not yet been released.
But I added a description of this improvement to the changelog. #6006

If this PR and the fix in the changelog are merged before the release, then it seems to me that it makes no sense to further clarify the changes from this PR.

@paulbalandan
Copy link
Member

Ohh. I thought this was documented already. Thanks for the clarification.

@MGatner MGatner added the database Issues or pull requests that affect the database layer label May 21, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't familiar with this syntax but tests pass and everyone else likes it so it's good by me. Thanks again @iRedds

@MGatner MGatner merged commit a034bcb into codeigniter4:develop May 21, 2022
@iRedds iRedds deleted the fix/oracle-table-alias branch May 22, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants