Skip to content

Add sample file for preloading #5974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2022
Merged

Add sample file for preloading #5974

merged 2 commits into from
May 26, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented May 8, 2022 •
edited
Loading

Needs to rebase after merging #5972
Ref #6000

Description

In the Welcome Page benchmark in my local, the values improved as follows:

280 rps --> 330

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft May 8, 2022 00:17
@kenjis kenjis mentioned this pull request May 10, 2022
Closed
@kenjis kenjis added the enhancement PRs that improve existing functionalities label May 17, 2022
@kenjis kenjis marked this pull request as ready for review May 23, 2022 09:52
@kenjis kenjis merged commit 346c18f into codeigniter4:develop May 26, 2022
@kenjis kenjis deleted the add-preload branch May 26, 2022 08:55
@kenjis kenjis mentioned this pull request Jun 7, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

enhancement PRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @paulbalandan