Skip to content

docs: clarify that current_url() returns URL based on Config\App #5808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2022
Merged

docs: clarify that current_url() returns URL based on Config\App #5808

merged 1 commit into from
Mar 20, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Mar 18, 2022 •
edited
Loading

Description
Fixes #5807

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Mar 18, 2022
@kenjis kenjis mentioned this pull request Mar 18, 2022
Closed
MGatner
MGatner approved these changes Mar 19, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wait to overhaul URIs in version 5. What a mess 😓

Good clarification.

@kenjis kenjis merged commit 2a1f23f into codeigniter4:develop Mar 20, 2022
@kenjis kenjis deleted the fix-current_url branch March 20, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: current_url() returning wrong value when different host

2 participants

@kenjis @MGatner