Improve exception logging

[paulbalandan]

Description
Closes #5677

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Why this PR is refactoring?
It seems it is enhancement.

[paulbalandan]

Why this PR is refactoring? It seems it is enhancement.

Changed title.

[kenjis]

Before:

CRITICAL - 2022-02-15 02:10:32 --> Cannot modify header information - headers already sent
#0 [internal function]: CodeIgniter\Debug\Exceptions->errorHandler(2, 'Cannot modify h...', '/Users/kenji/wo...', 11)
#1 /Users/kenji/work/codeigniter/CodeIgniter4/app/Controllers/Home.php(11): setcookie('printer', '37')
#2 /Users/kenji/work/codeigniter/CodeIgniter4/system/CodeIgniter.php(834): App\Controllers\Home->index()
#3 /Users/kenji/work/codeigniter/CodeIgniter4/system/CodeIgniter.php(421): CodeIgniter\CodeIgniter->runController(Object(App\Controllers\Home))
#4 /Users/kenji/work/codeigniter/CodeIgniter4/system/CodeIgniter.php(329): CodeIgniter\CodeIgniter->handleRequest(NULL, Object(Config\Cache), false)
#5 /Users/kenji/work/codeigniter/CodeIgniter4/public/index.php(37): CodeIgniter\CodeIgniter->run()
#6 /Users/kenji/work/codeigniter/CodeIgniter4/system/Commands/Server/rewrite.php(43): require_once('/Users/kenji/wo...')
#7 {main}

After:

CRITICAL - 2022-02-15 02:12:17 --> Cannot modify header information - headers already sent
in APPPATH/Controllers/Home.php on line 11.
 1 [internal function]: CodeIgniter\Debug\Exceptions->errorHandler(2, 'Cannot modify header information - headers already sent', 'APPPATH/Controllers/Home.php', 11)
 2 APPPATH/Controllers/Home.php(11): setcookie('printer', '37')
 3 SYSTEMPATH/CodeIgniter.php(834): App\Controllers\Home->index()
 4 SYSTEMPATH/CodeIgniter.php(421): CodeIgniter\CodeIgniter->runController(Object(App\Controllers\Home))
 5 SYSTEMPATH/CodeIgniter.php(329): CodeIgniter\CodeIgniter->handleRequest(null, Object(Config\Cache), false)
 6 FCPATH/index.php(37): CodeIgniter\CodeIgniter->run()
 7 SYSTEMPATH/Commands/Server/rewrite.php(43): require_once('FCPATH/index.php')

[kenjis]

Why do you start with 1, not 0?

[paulbalandan]

I feel that's more "natural" way of counting. No offense to zero-based array counting. 😂

[sclubricants]

$idx = str_pad((string) ++$idx, 2, '#', STR_PAD_LEFT);

This is like the original.

[paulbalandan]

This is like the original.

This would fail on idx >= 10. https://3v4l.org/DAqmo

[sclubricants]

https://3v4l.org/dFGjg

echo '#'.str_pad(++$idx, 3, ' ', STR_PAD_RIGHT).'Some more text', PHP_EOL;

[kenjis]

@paulbalandan The log format will be changed. If a user watches log files and parse it to check the error, it may break.
I think it is better to add to changelog.