Skip to content

fix: do not call header() if headers have already been sent #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2022
Merged

fix: do not call header() if headers have already been sent #5680

merged 1 commit into from
Feb 12, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Feb 12, 2022 •
edited
Loading

Description
Fixes #5679

Before:
Screenshot 2022-02-12 13 02 08

After:
Screenshot 2022-02-12 13 02 12

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 12, 2022
@kenjis kenjis mentioned this pull request Feb 12, 2022
Closed
@kenjis kenjis merged commit 90257e5 into codeigniter4:develop Feb 12, 2022
@kenjis kenjis deleted the fix-exceptionHandler-header branch February 12, 2022 22:10
@sclubricants sclubricants mentioned this pull request Mar 21, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: CodeIgniter\Debug\Exceptions::exceptionHandler() sending header causes error if headers already sent

3 participants

@kenjis @lonnieezell @paulbalandan