Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Feb 3, 2022

Description
The current CLIRequest does not know whether it is Spark request or PHP CLI request.

  • add CLIRequest::isSparked()
  • spark command uses sparked CLIRequest
  • and we will not need the constant SPARKED that makes testing difficult

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Feb 3, 2022
@kenjis
Copy link
Member Author

kenjis commented Feb 3, 2022

I thought again, and changed my mind.
I'll take this down for now.

@kenjis kenjis closed this Feb 3, 2022
@kenjis kenjis deleted the refactor-SPARKED branch August 27, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants