fix: BaseConnection::getConnectDuration() number_format(): Passing null to parameter #5536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at is deprecated Fixes codeigniter4#5535
kenjis
added
the
bug
paulbalandan
approved these changes
Jan 4, 2022
MGatner
approved these changes
Jan 4, 2022
Member
|
@kenjis Do you think this is high priority enough to merit a hotfix release? |
kenjis
added a commit
that referenced
this pull request
Jan 8, 2022
fix: BaseConnection::getConnectDuration() number_format(): Passing null to parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5535
I've confirmed this error when only connecting db but not running any queries.
The bug reporter confirmed this fix: #5535 (comment)
Checklist: