Skip to content

[Rector] Apply Rector: VarConstantCommentRector #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2021
Merged

[Rector] Apply Rector: VarConstantCommentRector #4759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77d7d1b
[Rector] Apply Rector: VarConstantCommentRector
samsonasik Jun 1, 2021
52a1823
remove @const
samsonasik Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Rector\CodeQuality\Rector\Return_\SimplifyUselessVariableRector;
use Rector\CodeQuality\Rector\Ternary\UnnecessaryTernaryExpressionRector;
use Rector\CodeQualityStrict\Rector\Variable\MoveVariableDeclarationNearReferenceRector;
use Rector\CodingStyle\Rector\ClassConst\VarConstantCommentRector;
use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
use Rector\Core\Configuration\Option;
use Rector\Core\ValueObject\PhpVersion;
Expand Down Expand Up @@ -92,4 +93,5 @@
$services->set(TernaryToNullCoalescingRector::class);
$services->set(ListToArrayDestructRector::class);
$services->set(MoveVariableDeclarationNearReferenceRector::class);
$services->set(VarConstantCommentRector::class);
};
4 changes: 4 additions & 0 deletions system/Cache/Handlers/BaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,15 @@ abstract class BaseHandler implements CacheInterface
/**
* Reserved characters that cannot be used in a key or tag.
* From https://github.com/symfony/cache-contracts/blob/c0446463729b89dd4fa62e9aeecc80287323615d/ItemInterface.php#L43
*
* @var string
*/
public const RESERVED_CHARACTERS = '{}()/\@:';

/**
* Maximum key length.
*
* @var int
*/
public const MAX_KEY_LENGTH = PHP_INT_MAX;

Expand Down
2 changes: 2 additions & 0 deletions system/Cache/Handlers/FileHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ class FileHandler extends BaseHandler
{
/**
* Maximum key length.
*
* @var int
*/
public const MAX_KEY_LENGTH = 255;

Expand Down
2 changes: 2 additions & 0 deletions system/CodeIgniter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ class CodeIgniter
{
/**
* The current version of CodeIgniter Framework
*
* @var string
*/
const CI_VERSION = '4.1.2';

Expand Down
2 changes: 2 additions & 0 deletions system/Cookie/CookieInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ interface CookieInterface
* Cookies will be sent in all contexts, i.e in responses to both
* first-party and cross-origin requests. If `SameSite=None` is set,
* the cookie `Secure` attribute must also be set (or the cookie will be blocked).
*
* @var string
*/
public const SAMESITE_NONE = 'none';

Expand Down
312 changes: 253 additions & 59 deletions system/HTTP/ResponseInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,77 +36,271 @@ interface ResponseInterface
/**
* Constants for status codes.
* From https://en.wikipedia.org/wiki/List_of_HTTP_status_codes
*
* @var int
*/
// Informational
const HTTP_CONTINUE = 100;
const HTTP_CONTINUE = 100;
/**
* @var int
*/
const HTTP_SWITCHING_PROTOCOLS = 101;
const HTTP_PROCESSING = 102;
const HTTP_EARLY_HINTS = 103;
/**
* @var int
*/
const HTTP_PROCESSING = 102;
/**
* @var int
*/
const HTTP_EARLY_HINTS = 103;
// Success
const HTTP_OK = 200;
const HTTP_CREATED = 201;
const HTTP_ACCEPTED = 202;
/**
* @var int
*/
const HTTP_OK = 200;
/**
* @var int
*/
const HTTP_CREATED = 201;
/**
* @var int
*/
const HTTP_ACCEPTED = 202;
/**
* @var int
*/
const HTTP_NONAUTHORITATIVE_INFORMATION = 203;
const HTTP_NO_CONTENT = 204;
const HTTP_RESET_CONTENT = 205;
const HTTP_PARTIAL_CONTENT = 206;
const HTTP_MULTI_STATUS = 207;
const HTTP_ALREADY_REPORTED = 208;
const HTTP_IM_USED = 226;
/**
* @var int
*/
const HTTP_NO_CONTENT = 204;
/**
* @var int
*/
const HTTP_RESET_CONTENT = 205;
/**
* @var int
*/
const HTTP_PARTIAL_CONTENT = 206;
/**
* @var int
*/
const HTTP_MULTI_STATUS = 207;
/**
* @var int
*/
const HTTP_ALREADY_REPORTED = 208;
/**
* @var int
*/
const HTTP_IM_USED = 226;
// Redirection
const HTTP_MULTIPLE_CHOICES = 300;
const HTTP_MOVED_PERMANENTLY = 301;
const HTTP_FOUND = 302;
const HTTP_SEE_OTHER = 303;
const HTTP_NOT_MODIFIED = 304;
const HTTP_USE_PROXY = 305;
const HTTP_SWITCH_PROXY = 306;
/**
* @var int
*/
const HTTP_MULTIPLE_CHOICES = 300;
/**
* @var int
*/
const HTTP_MOVED_PERMANENTLY = 301;
/**
* @var int
*/
const HTTP_FOUND = 302;
/**
* @var int
*/
const HTTP_SEE_OTHER = 303;
/**
* @var int
*/
const HTTP_NOT_MODIFIED = 304;
/**
* @var int
*/
const HTTP_USE_PROXY = 305;
/**
* @var int
*/
const HTTP_SWITCH_PROXY = 306;
/**
* @var int
*/
const HTTP_TEMPORARY_REDIRECT = 307;
/**
* @var int
*/
const HTTP_PERMANENT_REDIRECT = 308;
// Client Error
const HTTP_BAD_REQUEST = 400;
const HTTP_UNAUTHORIZED = 401;
const HTTP_PAYMENT_REQUIRED = 402;
const HTTP_FORBIDDEN = 403;
const HTTP_NOT_FOUND = 404;
const HTTP_METHOD_NOT_ALLOWED = 405;
const HTTP_NOT_ACCEPTABLE = 406;
const HTTP_PROXY_AUTHENTICATION_REQUIRED = 407;
const HTTP_REQUEST_TIMEOUT = 408;
const HTTP_CONFLICT = 409;
const HTTP_GONE = 410;
const HTTP_LENGTH_REQUIRED = 411;
const HTTP_PRECONDITION_FAILED = 412;
const HTTP_PAYLOAD_TOO_LARGE = 413;
const HTTP_URI_TOO_LONG = 414;
const HTTP_UNSUPPORTED_MEDIA_TYPE = 415;
const HTTP_RANGE_NOT_SATISFIABLE = 416;
const HTTP_EXPECTATION_FAILED = 417;
const HTTP_IM_A_TEAPOT = 418;
const HTTP_MISDIRECTED_REQUEST = 421;
const HTTP_UNPROCESSABLE_ENTITY = 422;
const HTTP_LOCKED = 423;
const HTTP_FAILED_DEPENDENCY = 424;
const HTTP_TOO_EARLY = 425;
const HTTP_UPGRADE_REQUIRED = 426;
const HTTP_PRECONDITION_REQUIRED = 428;
const HTTP_TOO_MANY_REQUESTS = 429;
/**
* @var int
*/
const HTTP_BAD_REQUEST = 400;
/**
* @var int
*/
const HTTP_UNAUTHORIZED = 401;
/**
* @var int
*/
const HTTP_PAYMENT_REQUIRED = 402;
/**
* @var int
*/
const HTTP_FORBIDDEN = 403;
/**
* @var int
*/
const HTTP_NOT_FOUND = 404;
/**
* @var int
*/
const HTTP_METHOD_NOT_ALLOWED = 405;
/**
* @var int
*/
const HTTP_NOT_ACCEPTABLE = 406;
/**
* @var int
*/
const HTTP_PROXY_AUTHENTICATION_REQUIRED = 407;
/**
* @var int
*/
const HTTP_REQUEST_TIMEOUT = 408;
/**
* @var int
*/
const HTTP_CONFLICT = 409;
/**
* @var int
*/
const HTTP_GONE = 410;
/**
* @var int
*/
const HTTP_LENGTH_REQUIRED = 411;
/**
* @var int
*/
const HTTP_PRECONDITION_FAILED = 412;
/**
* @var int
*/
const HTTP_PAYLOAD_TOO_LARGE = 413;
/**
* @var int
*/
const HTTP_URI_TOO_LONG = 414;
/**
* @var int
*/
const HTTP_UNSUPPORTED_MEDIA_TYPE = 415;
/**
* @var int
*/
const HTTP_RANGE_NOT_SATISFIABLE = 416;
/**
* @var int
*/
const HTTP_EXPECTATION_FAILED = 417;
/**
* @var int
*/
const HTTP_IM_A_TEAPOT = 418;
/**
* @var int
*/
const HTTP_MISDIRECTED_REQUEST = 421;
/**
* @var int
*/
const HTTP_UNPROCESSABLE_ENTITY = 422;
/**
* @var int
*/
const HTTP_LOCKED = 423;
/**
* @var int
*/
const HTTP_FAILED_DEPENDENCY = 424;
/**
* @var int
*/
const HTTP_TOO_EARLY = 425;
/**
* @var int
*/
const HTTP_UPGRADE_REQUIRED = 426;
/**
* @var int
*/
const HTTP_PRECONDITION_REQUIRED = 428;
/**
* @var int
*/
const HTTP_TOO_MANY_REQUESTS = 429;
/**
* @var int
*/
const HTTP_REQUEST_HEADER_FIELDS_TOO_LARGE = 431;
const HTTP_UNAVAILABLE_FOR_LEGAL_REASONS = 451;
const HTTP_CLIENT_CLOSED_REQUEST = 499;
/**
* @var int
*/
const HTTP_UNAVAILABLE_FOR_LEGAL_REASONS = 451;
/**
* @var int
*/
const HTTP_CLIENT_CLOSED_REQUEST = 499;
// Server Error
const HTTP_INTERNAL_SERVER_ERROR = 500;
const HTTP_NOT_IMPLEMENTED = 501;
const HTTP_BAD_GATEWAY = 502;
const HTTP_SERVICE_UNAVAILABLE = 503;
const HTTP_GATEWAY_TIMEOUT = 504;
const HTTP_HTTP_VERSION_NOT_SUPPORTED = 505;
const HTTP_VARIANT_ALSO_NEGOTIATES = 506;
const HTTP_INSUFFICIENT_STORAGE = 507;
const HTTP_LOOP_DETECTED = 508;
const HTTP_NOT_EXTENDED = 510;
/**
* @var int
*/
const HTTP_INTERNAL_SERVER_ERROR = 500;
/**
* @var int
*/
const HTTP_NOT_IMPLEMENTED = 501;
/**
* @var int
*/
const HTTP_BAD_GATEWAY = 502;
/**
* @var int
*/
const HTTP_SERVICE_UNAVAILABLE = 503;
/**
* @var int
*/
const HTTP_GATEWAY_TIMEOUT = 504;
/**
* @var int
*/
const HTTP_HTTP_VERSION_NOT_SUPPORTED = 505;
/**
* @var int
*/
const HTTP_VARIANT_ALSO_NEGOTIATES = 506;
/**
* @var int
*/
const HTTP_INSUFFICIENT_STORAGE = 507;
/**
* @var int
*/
const HTTP_LOOP_DETECTED = 508;
/**
* @var int
*/
const HTTP_NOT_EXTENDED = 510;
/**
* @var int
*/
const HTTP_NETWORK_AUTHENTICATION_REQUIRED = 511;
const HTTP_NETWORK_CONNECT_TIMEOUT_ERROR = 599;
/**
* @var int
*/
const HTTP_NETWORK_CONNECT_TIMEOUT_ERROR = 599;

/**
* Gets the response status code.
Expand Down
Loading