Use verbose DB output for errors #4276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Feb 13, 2021
paulbalandan
force-pushed
the
verbose-db-error-output
branch
from
ea83359 to
d42a419
Compare
MGatner
requested changes
Feb 16, 2021
paulbalandan
force-pushed
the
verbose-db-error-output
branch
from
d42a419 to
0690104
Compare
MGatner
requested changes
Feb 17, 2021
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
One question, but overall this looks like a vast improvement. I like the differentiation between primary and failover errors, nice touch!
paulbalandan
force-pushed
the
verbose-db-error-output
branch
from
0690104 to
1ce1f8f
Compare
paulbalandan
force-pushed
the
verbose-db-error-output
branch
from
1ce1f8f to
51fa043
Compare
paulbalandan
force-pushed
the
verbose-db-error-output
branch
from
51fa043 to
6214b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the error output for DB connections to be more verbose than the generic
Unable to connect to the database.. This is an attempt to reduce questions on the forum regarding this despite raising the logging threshold to4.php spark migrate --allChecklist: