-
Notifications
You must be signed in to change notification settings - Fork 2k
Abstraction for cookies and cookie collections #4193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstraction for cookies and cookie collections #4193
Conversation
79693a2 to
f3f84a9
Compare
f4c6347 to
fc66a8f
Compare
fc66a8f to
370aabf
Compare
|
you can rewrite my solution if don't want read manuals.. |
Before posting this PR, I've read the php manual on this as well as the relevant RFCs. I've even consulted MDN for latest behavior of modern browsers for cookies. So I'd say this is researched and not just simply putting some code. |
370aabf to
f046c64
Compare
michalsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good job. I like how it looks - well thought out.
Not sure if this kind of change should target the PATCH version... but we don't really know what version the next release will have, so I guess it's okay.
|
This can be merged, right? |
|
Thanks for the reviews. @lonnieezell , I just have some minor phpdoc revisions to do later this day and I'll merge this right after. |
f046c64 to
348af2e
Compare
348af2e to
6367766
Compare
Description
This introduces a new
Cookieclass and theCookieStorefor holding a collection of cookies.CookieInterfacedefines the basic methods for all HTTP cookies.CloneableCookieInterface, which extendsCookieInterfacedefines methods of an immutable HTTP cookie.CookieimplementingCloneableCookieInterfacerepresenting an immutable HTTP cookie object.CookieStorerepresents an immutable collection of Cookie objects.Supersedes #4092 .
Replaces and closes #3983 .
Checklist: