Skip to content

Response Standards #3864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

Response Standards #3864

merged 1 commit into from
Nov 10, 2020

Conversation

@MGatner
Copy link
Member

@MGatner MGatner commented Nov 7, 2020 •
edited
Loading

Description
Standardizes CodeIgniter.php's handling of responses with ResponseInterface. Also makes sure always to check $returnResponse, even after Filters return (fixes an issue reported in #3863, superseded).

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@MGatner MGatner requested a review from paulbalandan November 9, 2020 16:33
@MGatner
Copy link
Member Author

MGatner commented Nov 9, 2020

Anyone for a review? This one should be all set.

@MGatner MGatner merged commit 3ca8ae4 into codeigniter4:develop Nov 10, 2020
@MGatner MGatner deleted the filter-tests branch November 10, 2020 00:38
@MGatner MGatner mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MGatner @lonnieezell