Skip to content

Add setSilent() method to URI class #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add setSilent() method to URI class #3000

wants to merge 3 commits into from

Conversation

@michalsn
Copy link
Member

@michalsn michalsn commented May 15, 2020

Description
Using $uri->setSilent() method will disable throwing exceptions. May be handy for using with methods like getSegment().

Ref: #2952, #2949

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

jreklund
jreklund suggested changes May 15, 2020
View reviewed changes
Copy link
Contributor

@jreklund jreklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we should reference it as $uri instead.

@michalsn
Copy link
Member Author

michalsn commented May 16, 2020

Oh great... now it not mergeable... I wonder what went wrong.

@michalsn
Copy link
Member Author

michalsn commented May 16, 2020

I don't know how to resolve this, so I'm closing this PR in favor of a new one: #3005

@michalsn michalsn closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jreklund jreklund jreklund requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michalsn @jreklund