Skip to content

fix. Time::setTimezone can't work #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2020
Merged

fix. Time::setTimezone can't work #2990

merged 3 commits into from
May 15, 2020

Conversation

@nyufeng
Copy link
Contributor

@nyufeng nyufeng commented May 14, 2020

Fix #2989
Time::setTimezone shuold same DateTime::setTimezone
Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

samsonasik
samsonasik reviewed May 14, 2020
View reviewed changes
@MGatner MGatner merged commit a2e469d into codeigniter4:develop May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Difference in behaviour of native DateTime::setTimezone() and CI's Time:setTimezone()

3 participants

@nyufeng @samsonasik @MGatner