Skip to content

Correction in Methods and Spellings #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 2, 2019
Merged

Correction in Methods and Spellings #1769

merged 4 commits into from
Mar 2, 2019

Conversation

@atishhamte
Copy link
Contributor

@atishhamte atishhamte commented Feb 28, 2019 •
edited
Loading

Some corrections in,

  • Method return type
  • Namespace
  • Return Type
  • Spellings
  • Logics

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

lonnieezell
lonnieezell requested changes Feb 28, 2019
View reviewed changes
@atishhamte
Copy link
Contributor Author

atishhamte commented Mar 1, 2019

When It will get merged? I am unable to generate new PR

@jim-parry
Copy link
Contributor

jim-parry commented Mar 1, 2019

Patience, young padawan!
You should be creating PR features in separate branches, rather than in your develop branch. Then you would be able to have multiple changes in progress at the same time.

@atishhamte
Copy link
Contributor Author

atishhamte commented Mar 1, 2019

Mistakenly I pushed it to develop, that's why I am asking.
Thanks

@atishhamte
Copy link
Contributor Author

atishhamte commented Mar 2, 2019

All the changes have been done as per @lonnieezell suggested

@lonnieezell lonnieezell merged commit a5fc95b into codeigniter4:develop Mar 2, 2019
@atishhamte atishhamte mentioned this pull request Mar 10, 2019
Merged
5 tasks
@MGatner MGatner mentioned this pull request Oct 16, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonnieezell lonnieezell lonnieezell requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atishhamte @jim-parry @lonnieezell