v4.3.8 release

[kenjis]

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/admin/RELEASE.md

• Prep for 4.3.8 release #7848
• 4.3.8 Ready code #7849

[kenjis]

It seems there is no epub userguide v4.3.8:
https://github.com/codeigniter4/userguide

There is no version in the commit message:
codeigniter4/userguide@368723d
and CodeIgniter.epub was created.

Manually renamed for now.
codeigniter4/userguide@9852f1c

[kenjis]

Run ./source/.github/scripts/deploy-userguide ${GITHUB_WORKSPACE}/source ${GITHUB_WORKSPACE}/userguide ${GITHUB_REF##*/}
  ./source/.github/scripts/deploy-userguide ${GITHUB_WORKSPACE}/source ${GITHUB_WORKSPACE}/userguide ${GITHUB_REF##*/}
  shell: /usr/bin/bash -e {0}
Preparing for version 
Merging files from /home/runner/work/CodeIgniter4/CodeIgniter4/source to /home/runner/work/CodeIgniter4/CodeIgniter4/userguide
error: pathspec 'master' did not match any file(s) known to git
Running Sphinx v4.3.2

https://github.com/codeigniter4/CodeIgniter4/actions/runs/5970889910/job/16199163159

The version number is missing.

Output:

Preparing for version 
Merging files from /home/runner/work/CodeIgniter4/CodeIgniter4/source to /home/runner/work/CodeIgniter4/CodeIgniter4/userguide

Shell script:

SOURCE=$1
TARGET=$2
RELEASE=$3
VERSION=`echo "$RELEASE" | cut -c 2-`

echo "Preparing for version $3"
echo "Merging files from $1 to $2"

Does anyone know why the script couldn't get the version number?

[paulbalandan]

${GITHUB_REF##*/} does not work anymore?

[kenjis]

No, when v4.4.0 was released, it worked.
https://github.com/codeigniter4/userguide

It might be a GitHub server issue. See #7854 (comment)

[paulbalandan]

But it was manually renamed, right?

[kenjis]

No, I manually renamed v4.3.8 epub. v4.4.0 epub was created automatically.

[paulbalandan]

Ah, I see you edited your comment. Maybe a glitch.
I think we can add an if check to see if release is ''