Bug: cli request is confusing

[itisjoby]

PHP Version

8.2

CodeIgniter4 Version

4.1.3

CodeIgniter4 Installation Method

Composer (using codeigniter4/appstarter)

Which operating systems have you tested for this bug?

Linux

Which server did you use?

apache

Database

Mongodb

What happened?

calling a webpage via cli is a pain in ci4. we faced a lot of issues when tried running a phpcode via terminal.

1. i had a fatal error in my initController function of parent class.but this was not shown to me instead it stopped the execution at my __destruct function complaining different issue.it took me a lot of time to identify the real problem
2. $this->request->uri is public in normal request(via browser) . but when running via a terminal it throws error Cannot access protected property CodeIgniter\HTTP\CLIRequest::$uri

Steps to Reproduce

ParentController.php.txt
Test.php.txt

(please rename the extension to .php as it wont allow me to upload this files)
run test.php

Expected Output

1. run via terminal/browser getting error at __destruct . it should have stoped at initcontroller right?
2. comment the line
   $this->dd(); //no such function fatal error
   run via terminal it should be working like running via a browser. now getting error: Cannot access protected property CodeIgniter\HTTP\CLIRequest::$uri

Anything else?

please suggest whether this was an error

[kenjis]

--- a/app/Config/Routes.php
+++ b/app/Config/Routes.php
@@ -19,7 +19,7 @@ $routes->set404Override();
 // where controller filters or CSRF protection are bypassed.
 // If you don't want to define all routes, please use the Auto Routing (Improved).
 // Set `$autoRoutesImproved` to true in `app/Config/Feature.php` and set the following to true.
-// $routes->setAutoRoute(false);
+$routes->setAutoRoute(true);
 
 /*
  * --------------------------------------------------------------------

<?php

namespace App\Controllers;

use AllowDynamicProperties;
use CodeIgniter\Controller;
use CodeIgniter\HTTP\CLIRequest;
use CodeIgniter\HTTP\IncomingRequest;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\ResponseInterface;
use Psr\Log\LoggerInterface;

/**
 * Class BaseController
 *
 * BaseController provides a convenient place for loading components
 * and performing functions that are needed by all your controllers.
 * Extend this class in any new controllers:
 *     class Home extends BaseController
 *
 * For security be sure to declare any new methods as protected or private.
 */
#[AllowDynamicProperties]
abstract class ParentController extends Controller
{
    /**
     * Instance of the main Request object.
     *
     * @var CLIRequest|IncomingRequest
     */
    protected $request;

    /**
     * An array of helpers to be loaded automatically upon
     * class instantiation. These helpers will be available
     * to all other controllers that extend BaseController.
     *
     * @var array
     */
    protected $helpers = [];

    /**
     * Be sure to declare properties for any property fetch you initialized.
     * The creation of dynamic property is deprecated in PHP 8.2.
     */
    // protected $session;

    public function __construct()
    {
    }

    /**
     * Constructor.
     */
    public function initController(RequestInterface $request, ResponseInterface $response, LoggerInterface $logger)
    {
        // Do Not Edit This Line
        parent::initController($request, $response, $logger);

        $this->dd(); // no such function fatal error
    }
}

<?php

namespace App\Controllers;

use AllowDynamicProperties;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\ResponseInterface;
use Psr\Log\LoggerInterface;

#[AllowDynamicProperties]
/**
 * @internal
 */
final class Test extends ParentController
{
    public function __construct()
    {
        parent::__construct();

        /* if (empty($_GET['pass_me_through'])) {
          die('temporarily stopped');
          } */
    }

    public function __destruct()
    {
        dd($this->page_info);
    }

    public function initController(RequestInterface $request, ResponseInterface $response, LoggerInterface $logger)
    {
        parent::initController($request, $response, $logger);
        $this->page_info = [];
    }

    public function index()
    {
        echo 'reached index';

        echo $this->request->uri->getTotalSegments();
        $this->page_info = [
            'status' => 'runned_fine',
        ];
    }
}

$ php public/index.php test


[ErrorException]

Undefined property: App\Controllers\Test::$page_info

at APPPATH/Controllers/Test.php:27

Backtrace:
  1    APPPATH/Controllers/Test.php:27
       CodeIgniter\Debug\Exceptions()->errorHandler(2, 'Undefined property: App\\Controllers\\Test::$page_info', '/Users/kenji/work/codeigniter/official/CodeIgniter4/app/Controllers/Test.php', 27)

  2    SYSTEMPATH/CodeIgniter.php:490
       App\Controllers\Test()->__destruct()

  3    SYSTEMPATH/CodeIgniter.php:368
       CodeIgniter\CodeIgniter()->handleRequest(null, Object(Config\Cache), false)

  4    FCPATH/index.php:67
       CodeIgniter\CodeIgniter()->run()

[kenjis]

run via terminal/browser getting error at __destruct . it should have stoped at initcontroller right?

Yes, it is better to show the first error, not the last. Try #7341

[kenjis]

$this->request->uri is public in normal request(via browser) . but when running via a terminal it throws error Cannot access protected property CodeIgniter\HTTP\CLIRequest::$uri

Sorry, $this->request->uri being public is a bug.
Please use $this->request->getUri() instead.

[itisjoby]

Thankyou very much.