`TimeTest::testGetAge` fails

[kenjis]

There was 1 failure:

1) CodeIgniter\I18n\TimeTest::testGetAge
Failed asserting that 4 is identical to 5.

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/I18n/TimeTest.php:399

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3399510319/jobs/5653309525

5 Nov 2017 - Daylight Saving Time Ended
When local daylight time was about to reach
Sunday, 5 November 2017, 02:00:00 clocks were turned backward 1 hour to
Sunday, 5 November 2017, 01:00:00 local standard time instead.
https://www.timeanddate.com/time/change/usa/chicago?year=2017

6 Nov 2022 - Daylight Saving Time Ends
When local daylight time is about to reach
Sunday, 6 November 2022, 02:00:00 clocks are turned backward 1 hour to
Sunday, 6 November 2022, 01:00:00 local standard time instead.
https://www.timeanddate.com/time/change/usa/chicago?year=2022

$testTime: 2022-11-05 10:14:35.000000 UTC
$ourTime: 2017-11-05 11:14:35.000000 UTC

CodeIgniter4/system/I18n/Time.php

Lines 1056 to 1062 in 5c2d10b

	public function difference($testTime, ?string $timezone = null)
	{
	$testTime = $this->getUTCObject($testTime, $timezone);
	$ourTime = $this->getUTCObject($this);
	return new TimeDifference($ourTime, $testTime);
	}

[kenjis]

'5 years ago' is the same time (07:17:03), but the timezone is different.
That is, 5 years ago is not true 5 years ago, but (5 years - 1 hour) in real time.

        d(Time::parse('5 years ago')->format('c')); // string (25) "2017-11-05T07:17:03-06:00"
        dd(Time::now()->format('c'));               // string (25) "2022-11-05T07:17:03-05:00"

[kenjis]

I do not know if this is a bug or not. But clearly it is not intuitive that this test fails.

CodeIgniter4/tests/system/I18n/TimeTest.php

Lines 395 to 401 in 5c2d10b

	public function testGetAge()
	{
	$time = Time::parse('5 years ago');
	$this->assertSame(5, $time->getAge());
	$this->assertSame(5, $time->age);
	}

[totoprayogo1916]

Maybe because of CST/CDT


https://www.worldtimebuddy.com/?pl=1&lid=100,6,5&h=100&hf=0

[totoprayogo1916]

date_default_timezone_set("America/Chicago");
d(date("e")); // "America/Chicago"
dd(date("T")); // "CDT"

[kenjis]

@totoprayogo1916 Yes, this is because of Daylight Saving Time.

[paulbalandan]

Can we change the default timezone of tests to use UTC? At least UTC is not affected by DST.

The switch to daylight saving time does not affect UTC. It refers to time on the zero or Greenwich meridian, which is not adjusted to reflect changes either to or from Daylight Saving Time.
https://www.nhc.noaa.gov/aboututc.shtml#:~:text=The%20switch%20to%20daylight%20saving,or%20from%20Daylight%20Saving%20Time.

[kenjis]

Daylight saving time, it's horrible.

[MGatner]

US is considering abolishing the shifts: https://en.m.wikipedia.org/wiki/Sunshine_Protection_Act

[kenjis]

@paulbalandan See #6826