Bug: [Validation] `required_without` will not work if the field is specified with asterisk

[kenjis]

See #5922 (comment)

The following test fails. The validation passes.

    public function testRequireWithoutWithWildCard()
    {
        $data = [
            'a' => [
                ['b' => 1, 'c' => 2],
                ['c' => ''],
            ],
        ];

        $this->validation->setRules([
            'a.*.c' => 'required_without[a.*.b]',
        ])->run($data);

        $this->assertSame(
            'The a.*.c field is required when a.*.b is not present.',
            $this->validation->getError('a.1.c')
        );
    }

[ping-yee]

I think the description of required_without is strange.

The field is required when all of the other fields are present in the data but not required.

Is the description different from the value of getError means ?

The a..c field is required when a..b is not present.

[ping-yee]

@kenjis What kind of design should I use?

[kenjis]

Is the description different from the value of getError means ?

Yes. The explanation is the same as the following comment, but it seems different from the Example blow:

CodeIgniter4/system/Validation/Rules.php

Lines 274 to 279 in ac2ad22

	* The field is required when all of the other fields are present
	* in the data but not required.
	*
	* Example (field is required when the id or email field is missing):
	*
	* required_without[id,email]

[ping-yee]

The field is required when all of the other fields are present in the data but not required.

I think this explanation and description of official document of required_without[] isn't right , the right explanation should be as below.

The field is required when any of the other required fields are not present in any data.

[ping-yee]

CodeIgniter4/system/Validation/Rules.php

Lines 302 to 304 in ac2ad22

	if ((strpos($field, '.') === false && (! array_key_exists($field, $data) || empty($data[$field]))) || (strpos($field, '.') !== false && empty(dot_array_search($field, $data)))) {
	return false;
	}

empty(dot_array_search($field, $data))

As the conditional shows, it judge whether the param field of required_without[] isn't presented in data.

For example:

public function testRequireWithoutWithWildCard()
    {
        $data = [
            'a' => [
                ['b' => 1, 'c' => 2],
                ['c' => ''],
            ],
        ];

        $this->validation->setRules([
            'a.*.c' => 'required_without[a.*.b]',
        ])->run($data);

        $this->assertSame(
            'The a.*.c field is required when a.*.b is not present.',
            $this->validation->getError('a.1.c')
        );
    }

In this test case, a.*.c field will be required when all of a.*.b field don't present in data.
If any data is presented in a.*.b field, a.*.c will not be required, so the dataset of this test case should be chaged as below.

$data = [
    'a' => [
        ['b' => '', 'c' => 2],
        ['c' => ''],
    ],
];

[kenjis]

@ping-yee Do you mean this is not a bug?

I thought that a.1.c field will be required when a.1.b field doesn't present in data.
It seems we need a realistic use case.

[ping-yee]

Do you mean this is not a bug?

Yes. I think this is not a bug, it just need to change the command out and the description of official document.

I thought that a.1.c field will be required when a.1.b field doesn't present in data.

Yes. It should be that.
So the data set of this case should be as below.

    public function testRequireWithoutWithWildCard()
    {
        $data = [
            'a' => [
                ['b' => '', 'c' => 2],
                ['c' => ''],
            ],
        ];

        $this->validation->setRules([
            'a.*.c' => 'required_without[a.*.b]',
        ])->run($data);

        $this->assertSame(
            'The a.*.c field is required when a.*.b is not present.',
            $this->validation->getError('a.1.c')
        );
    }

When a.0.b field doesn't present in data, the a.0.c and a.1.c field will be required.
But a.1.c field doesn't have any data, it will get the error The a.*.c field is required when a.*.b is not present..

[kenjis]

When a.0.b field doesn't present in data, the a.0.c and a.1.c field will be required.

I thought the checking should be done for each array (a.0, a.1).
When a.0.b field does not pass required check, the a.0.c field will be required.
When a.1.b field does not pass required check, the a.1.c field will be required.

[MGatner]

I read through this whole thread and thought to myself: "has our validation system gotten too abstruse?"

I can't think of an example where I would use this, but also it seems so difficult to understand I think if I did have such a case I would break it into smaller validations.