Using Java 7 instead of Java 1 and custom code #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plexus Utils still requires Java 6. Parts of this PR aren't possible. |
|
@michael-o It might be a good idea if Travis could check wheter JRE 7+ code used, to prevent people like me sending such PRs. :-) |
|
We have an enforcer rule for that. In fact, it does use Java 7 code but only if Java 7 is used at runtime. |
|
I divided my commits into two separate PRs, one for Java 6 and one for Java 7. Please see #31 for the changes which work on Java 6. I'd like to propose to open a branch for future Java 7 changes. |
|
As soon as we start using Java 7 these methods get obsolete, I'd deprecate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly improving performance and reducing code size by replacement of custom code and Java 1 by Java 7.