plexus-compiler-eclipse does not respect excludes for source

[wilx]

I am having issues with excludes for source files not working when using plexus-compiler-eclipse and <compilerId>eclipse</compilerId>. It works just fine when using <compilerId>javac</compilerId>. I have prepared a reproduction test case at https://github.com/wilx/plexus-compiler-eclipse-issue.

This is important to work if I want to compile most of the sources with specific Java target and some with different Java target.

[pzygielo]

I think, this is due to the fact, that at

plexus-compiler/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java

Line 77 in 9c6c1a1

public CompilerResult performCompile( CompilerConfiguration config )

config has no *cludes set. My understanding is that this should be (globally) addressed in MCOMPILER, somewhere in AbstractCompilerMojo.execute, where CompilerConfiguration is prepared.

This perhaps could also be patched here, to use

    config.getSourceFiles()

which is already populated (with *cludes honoured it seems) instead of

plexus-compiler/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java

Line 246 in 9c6c1a1

Set<String> ss = getSourceFilesForSourceRoot( config, source );

(getSourceFilesForSourceRoot tries to use *cludes but they are empty).

But this

• MCOMPILER-347: Includes and excludes not passed into CompilerConfiguration

was closed as won't fix. @olamy - perhaps this could be re-evaluated and re-opened?

• [MCOMPILER-347] Set Xcludes in config passed to actual compiler apache/maven-compiler-plugin#101

[wilx]

Well, that might help. But why should the Plexus Eclipse compiler even try to re-scan for the sources when the passed CompilerConfiguration config instance already has them and correctly filtered from AbstractCompilerMojo? You can already get the sources set in org.codehaus.plexus.compiler.eclipse.EclipseJavaCompiler#performCompile via config.getSourceFiles()?

[famod]

FWIW, with #233 EclipseJavaCompiler will now respect CompilerConfiguration.sourceFiles. The change hasn't been released yet, though.

[famod]

This is fixed in 2.12.1 which was released yesterday (thanks @olamy btw!).

[wilx]

Works for my test.