Skip to content

Refactor some old java APIs usage #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 31, 2018
Merged

Refactor some old java APIs usage #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
565928e
Replace Vector with ArrayList
rfscholte Dec 31, 2018
30ceb00
Replace StringBuffer with StringBuilder
rfscholte Dec 31, 2018
11700bd
Update surefire
rfscholte Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modello-core/src/main/java/org/codehaus/modello/plugin/AbstractModelloGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ protected String capitalise( String str )
return str;
}

return new StringBuffer( str.length() )
return new StringBuilder( str.length() )
.append( Character.toTitleCase( str.charAt( 0 ) ) )
.append( str.substring( 1 ) )
.toString();
Expand Down Expand Up @@ -220,7 +220,7 @@ public static String uncapitalise( String str )
return str;
}

return new StringBuffer( str.length() )
return new StringBuilder( str.length() )
.append( Character.toLowerCase( str.charAt( 0 ) ) )
.append( str.substring( 1 ) )
.toString();
Expand Down
4 changes: 2 additions & 2 deletions modello-maven-plugin/src/it/maven-model/src/main/mdo/maven.mdo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@
<code><![CDATA[
public String getId()
{
StringBuffer id = new StringBuffer();
StringBuilder id = new StringBuilder();

id.append( getGroupId() );
id.append( ":" );
Expand Down Expand Up @@ -1748,7 +1748,7 @@
<code><![CDATA[
public String getId()
{
StringBuffer id = new StringBuffer();
StringBuilder id = new StringBuilder();

id.append( getGroupId() );
id.append( ":" );
Expand Down
2 changes: 1 addition & 1 deletion modello-plugins/modello-plugin-converters/src/test/resources/models/maven.mdo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@
<code>
public String getId()
{
StringBuffer id = new StringBuffer();
StringBuilder id = new StringBuilder();

id.append( getGroupId() );
id.append( ":" );
Expand Down
2 changes: 1 addition & 1 deletion modello-plugins/modello-plugin-dom4j/src/test/resources/maven.mdo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@
<code>
public String getId()
{
StringBuffer id = new StringBuffer();
StringBuilder id = new StringBuilder();

id.append( getGroupId() );
id.append( ":" );
Expand Down
2 changes: 1 addition & 1 deletion modello-plugins/modello-plugin-jackson/src/test/resources/maven.mdo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@
<code>
public String getId()
{
StringBuffer id = new StringBuffer();
StringBuilder id = new StringBuilder();

id.append( getGroupId() );
id.append( ":" );
Expand Down
6 changes: 3 additions & 3 deletions ...ello-plugin-java/src/main/java/org/codehaus/modello/plugin/java/JavaModelloGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ private JMethod generateToString( ModelClass modelClass, boolean onlyIdentifierF
}
else
{
sc.add( "StringBuffer buf = new StringBuffer( 128 );" );
sc.add( "StringBuilder buf = new StringBuilder( 128 );" );
}

sc.add( "" );
Expand Down Expand Up @@ -1246,7 +1246,7 @@ private JMethod createGetter( JField field, ModelField modelField )

JMethod getter = new JMethod( prefix + propertyName, returnType, null );

StringBuffer comment = new StringBuffer( "Get " );
StringBuilder comment = new StringBuilder( "Get " );
if ( StringUtils.isEmpty( modelField.getDescription() ) )
{
comment.append( "the " );
Expand Down Expand Up @@ -1286,7 +1286,7 @@ private JMethod createSetter( JField field, ModelField modelField, boolean isBui
setter = new JMethod( "set" + propertyName );
}

StringBuffer comment = new StringBuffer( "Set " );
StringBuilder comment = new StringBuilder( "Set " );
if ( StringUtils.isEmpty( modelField.getDescription() ) )
{
comment.append( "the " );
Expand Down
Loading