Use _id when unmarshalling team members API response #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierang-contino
requested review from
a team,
denis-codefresh and
yaroslav-codefresh
as code owners
korenyoni
approved these changes
Oct 18, 2022
Contributor
korenyoni
left a comment
korenyoni
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use _id when unmarshalling the API response for team members
Why
Recent versions of the codefresh API do not return
idfor team members, only_id. See #93 for more detailsNotes
Closes #93