Add logic to not return error in DeleteUser when no user is found #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good to me. Just make the indentation to match the surrounding code and we are good to merge. |
Fix whitespace as per feedback Co-authored-by: Denis Melnik <[email protected]>
denis-codefresh
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response when a user does not exist is: something like:
{"status":500,"code":"1001","name":"INTERNAL_SERVER_ERROR","message":"could not delete user:, err: "User does not exist"","context":{}}
It really should be a 404, but to change the api would be a breaking-change. Instead, we should parse the response and return an err only if the RequestAPI returns an error and the response does not contain "User does not exist".