trigger build #16
Merged
trigger build #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
| FROM alpine:3.12.4 | ||
|
|
||
| RUN apk add --no-cache git~=2.22 bash openssh | ||
| RUN apk add --no-cache git bash openssh |
Contributor
There was a problem hiding this comment.
The version of the git package should be pinned, otherwise it has a chance to get updated with some breaking changes next time somebody runs a build
Dockerfile.aarch64
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM arm64v8/alpine:3.7 | |||
| FROM arm64v8/alpine:3.12.4 | |||
Contributor
There was a problem hiding this comment.
The Dockerfile.aarch64 is actually not used anywhere, so this change is redundant
alex-codefresh
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.